shwstppr commented on a change in pull request #5786:
URL: https://github.com/apache/cloudstack/pull/5786#discussion_r825881676
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -4067,21 +4166,21 @@ public Vlan createVlanAndPublicIpRange(final
CreateVlanIpRangeCmd cmd) throws In
zoneId = network.getDataCenterId();
physicalNetworkId = network.getPhysicalNetworkId();
}
- } else if (ipv6) {
+ }/* else if (ipv6) {
throw new InvalidParameterValueException("Only support IPv6 on
extending existed network");
- }
+ }*/
// Verify that zone exists
final DataCenterVO zone = _zoneDao.findById(zoneId);
if (zone == null) {
throw new InvalidParameterValueException("Unable to find zone by
id " + zoneId);
}
- if (ipv6) {
- if (network.getGuestType() != GuestType.Shared ||
zone.isSecurityGroupEnabled()) {
- throw new InvalidParameterValueException("Only support IPv6 on
extending existed share network without SG");
- }
- }
+// if (ipv6) {
Review comment:
@weizhouapache Offering creation was guarded behind global setting with
suggestion from @DaanHoogland so the IPv6 offering doesn't get presented to
normal user when the offering is created by mistake. Adding IPv6 range is again
an admin only functionality and it will work only when admin will provide valid
IPv6 range/prefix. Does it still need to be guarded with global setting?
Global setting can be renamed but `Ipv6NetworkEnabled` might be confusing
with IPv6 shared networks functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
