sureshanaparti commented on a change in pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#discussion_r826906148
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/KvmNonManagedStorageDataMotionStrategy.java
##########
@@ -82,10 +82,13 @@
*/
@Override
protected StrategyPriority internalCanHandle(Map<VolumeInfo, DataStore>
volumeMap, Host srcHost, Host destHost) {
- if (super.internalCanHandle(volumeMap, srcHost, destHost) !=
StrategyPriority.CANT_HANDLE
- || canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap,
srcHost, destHost) != StrategyPriority.CANT_HANDLE) {
+ if (super.internalCanHandle(volumeMap, srcHost, destHost) !=
StrategyPriority.CANT_HANDLE) {
return StrategyPriority.CANT_HANDLE;
}
+ if (super.internalCanHandle(volumeMap, srcHost, destHost) ==
StrategyPriority.CANT_HANDLE &&
Review comment:
@Pearl1594 this check may not be required, it returns true always.
```suggestion
else if (canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap,
srcHost, destHost) != StrategyPriority.CANT_HANDLE) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
