GabrielBrascher commented on pull request #6116: URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068884645
@weizhouapache thanks for pinging me. I will double-check the file history to get some context and remember what changed over time and why. Thanks for stepping up with this PR, @Pearl1594! I believe that most of the work I've done on that PR was related to extracting a few validations added by @nvazquez in https://github.com/apache/cloudstack/commit/0fbf5006b87b6c5bc6188e3e1dd226a98c3bb453 and align with the workflow in case of `Local volume` +` attached data disks`. Might be good if @nvazquez can join us and double-check it as well. I have some meetings and tasks to run. Get back as soon as I can to refresh my memory and re-debug this flow. Regarding @Pearl1594`s comment in https://github.com/apache/cloudstack/pull/6116#issuecomment-1068867617 @Pearl1594 I believe that you are right indeed. There are some special cases to be handled, with regards to being NFS migration or a local storage migration, which led to the subsequent checks you've referenced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
