weizhouapache commented on pull request #6116:
URL: https://github.com/apache/cloudstack/pull/6116#issuecomment-1068931677
> > > I am not sure if it would be correct @weizhouapache (I may be wrong),
but based on the 4.15.2 code , it looks like if the strategy returned by
`canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost, destHost` is
CANT_HANDLE, then there are some subsequent checks done before returning can't
handle
> > > ```
> > > if (canHandleKVMNonManagedLiveNFSStorageMigration(volumeMap, srcHost,
destHost) == StrategyPriority.CANT_HANDLE) {
> > > Set<VolumeInfo> volumeInfoSet = volumeMap.keySet();
> > >
> > > for (VolumeInfo volumeInfo : volumeInfoSet) {
> > > StoragePoolVO storagePoolVO =
_storagePoolDao.findById(volumeInfo.getPoolId());
> > > if (storagePoolVO.getPoolType() !=
StoragePoolType.Filesystem && storagePoolVO.getPoolType() !=
StoragePoolType.NetworkFilesystem) {
> > > return StrategyPriority.CANT_HANDLE;
> > > }
> > > }
> > > }
> > > ```
> >
> >
> > @Pearl1594 OK, so the logic in this PR looks like same as what before
#5410 , right ?
>
> Yes @weizhouapache
@Pearl1594
OK, looks good to me. let's wait for the smoke test results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
