SadiJr commented on code in PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#discussion_r846007390
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -2424,7 +2425,9 @@ private void setParameters(SearchCriteria<IPAddressVO>
sc, final ListPublicIpAdd
sc.setParameters("state", state);
}
- sc.setParameters( "forsystemvms", false);
+ if (sourceNetworkId == null &&
IpAddressManagerImpl.SystemVmPublicIpReservationModeStrictness.value()) {
+ sc.setParameters("forsystemvms", false);
+ }
Review Comment:
Hi @weizhouapache
I apologize for the delay in my answer. I've been pretty busy the last few
weeks, and I ended up not having time to review this PR. I will implement and
test your suggestion. Thanks for the suggestion and I apologize again for the
delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
