weizhouapache commented on code in PR #5902:
URL: https://github.com/apache/cloudstack/pull/5902#discussion_r848696111
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -2424,7 +2425,9 @@ private void setParameters(SearchCriteria<IPAddressVO>
sc, final ListPublicIpAdd
sc.setParameters("state", state);
}
- sc.setParameters( "forsystemvms", false);
+ if (sourceNetworkId == null &&
IpAddressManagerImpl.SystemVmPublicIpReservationModeStrictness.value()) {
+ sc.setParameters("forsystemvms", false);
+ }
Review Comment:
@SadiJr
no problem. thanks for your reply.
The 4.17.0.0 code freeze date is very close. If you want this PR to be
included, please update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
