slavkap commented on code in PR #6399:
URL: https://github.com/apache/cloudstack/pull/6399#discussion_r877195159
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -54,13 +54,6 @@
*/
public static final Property<Boolean>
ENABLE_MANUALLY_SETTING_CPU_TOPOLOGY_ON_KVM_VM = new
Property<Boolean>("enable.manually.setting.cpu.topology.on.kvm.vm", true);
- /**
- * Enable manually IO driver on KVM's VM. <br>
- * Data type: boolean.<br>
- * Default value: false.
- */
- public static final Property<Boolean> ENABLE_IO_URING = new
Property<>("enable.io.uring", false);
-
Review Comment:
I think it's good to leave this option also ... in case the check isn't
enough (in future) or the user wants to disable the `io_uring` even if it is
supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]