nvazquez commented on code in PR #6399:
URL: https://github.com/apache/cloudstack/pull/6399#discussion_r877347954


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2949,6 +2949,23 @@ private KVMPhysicalDisk 
getPhysicalDiskPrimaryStore(PrimaryDataStoreTO primaryDa
         return storagePool.getPhysicalDisk(data.getPath());
     }
 
+    /**
+     * Check if IO_URING is supported by qemu
+     */
+    protected boolean isIoUringSupportedByQemu() {
+        s_logger.debug("Checking if iouring is supported");
+        String hostOsKey = "Host.OS";
+        Map<String, String> versionStrings = getVersionStrings();
+        if (MapUtils.isEmpty(versionStrings) || 
!versionStrings.containsKey(hostOsKey)) {
+            return false;
+        }
+        String os = versionStrings.get(hostOsKey);
+        String qemuBinary = os.equalsIgnoreCase("ubuntu") ? 
"/usr/bin/qemu-system-x86_64" : "/usr/libexec/qemu-kvm";

Review Comment:
   This was regarding the qemu and libvirtd versions (< 5.0 and <6.3.0) - not 
an issue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to