NuxRo commented on code in PR #6399:
URL: https://github.com/apache/cloudstack/pull/6399#discussion_r877202113
##########
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:
##########
@@ -54,13 +54,6 @@
*/
public static final Property<Boolean>
ENABLE_MANUALLY_SETTING_CPU_TOPOLOGY_ON_KVM_VM = new
Property<Boolean>("enable.manually.setting.cpu.topology.on.kvm.vm", true);
- /**
- * Enable manually IO driver on KVM's VM. <br>
- * Data type: boolean.<br>
- * Default value: false.
- */
- public static final Property<Boolean> ENABLE_IO_URING = new
Property<>("enable.io.uring", false);
-
Review Comment:
@nvazquez +1 for optional properties entry, people might want to disable it,
it's new tech, might misbehave etc.
agent.properties should have the last word on whether it's enabled or not,
imho, if it's not too much bother.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
