DaanHoogland commented on code in PR #6413:
URL: https://github.com/apache/cloudstack/pull/6413#discussion_r903308471
##########
engine/components-api/src/main/java/com/cloud/capacity/CapacityManager.java:
##########
@@ -40,57 +40,86 @@ public interface CapacityManager {
static final String StorageCapacityDisableThresholdCK =
"pool.storage.capacity.disablethreshold";
static final String StorageOverprovisioningFactorCK =
"storage.overprovisioning.factor";
static final String StorageAllocatedCapacityDisableThresholdCK =
"pool.storage.allocated.capacity.disablethreshold";
- static final String VmwareCreateCloneFullCK = "vmware.create.full.clone";
-
- static final ConfigKey<Float> CpuOverprovisioningFactor = new
ConfigKey<Float>(Float.class, CpuOverprovisioningFactorCK, "Advanced", "1.0",
- "Used for CPU overprovisioning calculation; available CPU will be
(actualCpuCapacity * cpu.overprovisioning.factor)", true,
ConfigKey.Scope.Cluster, null);
- static final ConfigKey<Float> MemOverprovisioningFactor = new
ConfigKey<Float>(Float.class, MemOverprovisioningFactorCK, "Advanced", "1.0",
- "Used for memory overprovisioning calculation", true,
ConfigKey.Scope.Cluster, null);
- static final ConfigKey<Double> StorageCapacityDisableThreshold = new
ConfigKey<Double>("Alert", Double.class, StorageCapacityDisableThresholdCK,
"0.85",
- "Percentage (as a value between 0 and 1) of storage utilization above
which allocators will disable using the pool for low storage available.", true,
- ConfigKey.Scope.Zone);
- static final ConfigKey<Double> StorageOverprovisioningFactor = new
ConfigKey<Double>("Storage", Double.class, StorageOverprovisioningFactorCK, "2",
- "Used for storage overprovisioning calculation; available storage will
be (actualStorageSize * storage.overprovisioning.factor)", true,
ConfigKey.Scope.StoragePool);
+
+ static final String CATEGORY_ADVANCED = "Advanced";
+ static final String CATEGORY_ALERT = "Alert";
+
+ static final ConfigKey<Float> CpuOverprovisioningFactor =
+ new ConfigKey<>(
+ Float.class,
+ CpuOverprovisioningFactorCK,
+ CATEGORY_ADVANCED,
+ "1.0",
+ "Used for CPU overprovisioning calculation; available CPU
will be (actualCpuCapacity * cpu.overprovisioning.factor)",
+ true,
+ ConfigKey.Scope.Cluster,
+ null);
Review Comment:
it is more readable this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
