DaanHoogland commented on code in PR #6413:
URL: https://github.com/apache/cloudstack/pull/6413#discussion_r903308956
##########
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java:
##########
@@ -163,6 +163,47 @@ public interface StorageManager extends StorageService {
true,
ConfigKey.Scope.Cluster,
null);
+ ConfigKey<Boolean> VmwareCreateCloneFull = new ConfigKey<>(Boolean.class,
+ "vmware.create.full.clone",
+ "Storage",
+ "false",
+ "If set to true, creates VMs as full clones on ESX hypervisor",
+ true,
+ ConfigKey.Scope.StoragePool,
+ null);
+ ConfigKey<Boolean> VmwareAllowParallelExecution = new
ConfigKey<>(Boolean.class,
+ "vmware.allow.parallel.command.execution",
+ "Advanced",
+ "false",
+ "allow commands to be executed in parallel in spite of
'vmware.create.full.clone' being set to true.",
+ true,
+ ConfigKey.Scope.Global,
+ null);
+
+ /**
+ * should we execute in sequence not involving any storages?
+ * @return tru if commands should execute in sequence
+ */
+ static boolean shouldExecuteInSequenceOnVmware() {
+ return shouldExecuteInSequenceOnVmware(null, null);
+ }
+
+ static boolean shouldExecuteInSequenceOnVmware(Long srcStoreId, Long
dstStoreId) {
+ final Boolean fullClone = getFullCloneConfiguration(srcStoreId) ||
getFullCloneConfiguration(dstStoreId);
+ final Boolean allowParallel = getAllowParallelExecutionConfiguration();
+ return fullClone && !allowParallel;
+ }
+
+ static Boolean getAllowParallelExecutionConfiguration() {
+ return VmwareAllowParallelExecution.value();
+ }
Review Comment:
for mocking in unit testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
