soreana commented on PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-1766644695
@DaanHoogland @shwstppr The PR is ready for review and test, please have a look. The following code block repeated in [ResetCfgCmd.java](https://github.com/Leaseweb/cloudstack/blob/aec06ab53df26607393d933e352e9b7b2f844fd1/api/src/main/java/org/apache/cloudstack/api/command/admin/config/ResetCfgCmd.java#L147-L172), [UpdateCfgCmd.java](https://github.com/Leaseweb/cloudstack/blob/aec06ab53df26607393d933e352e9b7b2f844fd1/api/src/main/java/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java#L194-L212), and [ListCfgsByCmd.java](https://github.com/Leaseweb/cloudstack/blob/aec06ab53df26607393d933e352e9b7b2f844fd1/api/src/main/java/org/apache/cloudstack/api/command/admin/config/ListCfgsByCmd.java#L194-L218). I don't have any nice way to extract it. Let me know if you have any better idea. ```java if (!matchesConfigurationGroup(cfgResponse)) { return; } cfgResponse.setObjectName("configuration"); if (getZoneId() != null) { cfgResponse.setScope("zone"); } if (getClusterId() != null) { cfgResponse.setScope("cluster"); } if (getStoragepoolId() != null) { cfgResponse.setScope("storagepool"); } if (getAccountId() != null) { cfgResponse.setScope("account"); } if (getDomainId() != null) { cfgResponse.setScope("domain"); } if (getImageStoreId() != null){ cfgResponse.setScope("imagestore"); } if (getNetworkId() != null) { cfgResponse.setScope("network"); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
