harikrishna-patnala commented on PR #8115: URL: https://github.com/apache/cloudstack/pull/8115#issuecomment-1769873299
template_deploy_as_is_details looks like this  The corresponding values in user_vm_deploy_as_is_details looks like this  So I dont think we can directly copy the template_deploy_as_is_details to user_vm_deploy_as_is_details as it is. If we have to do that, we need a logic to differentiate the properties entries of templates and their values in the same table "user_vm_deploy_as_is_details", which I'm not sure if it is possible. May be @nvazquez can help here. Currently we are parsing everything from user_vm_deploy_as_is_details table and passing them to the resource. https://github.com/shapeblue/cloudstack/blob/4a0636374931e4e6b562def76acb9f8673a7f22a/engine/storage/src/main/java/org/apache/cloudstack/storage/image/deployasis/DeployAsIsHelperImpl.java#L317-L324 To simplify all these, I thought it will be better to keep the template_deploy_as_is_details even after deletion. Or else like I mentioned in the issue ticket, we need another column in user_vm_deploy_as_is details table which is "is_password", because thats the only field we are looking in template details table. cc @DaanHoogland @weizhouapache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
