DaanHoogland commented on code in PR #8115:
URL: https://github.com/apache/cloudstack/pull/8115#discussion_r1367068378
##########
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##########
@@ -665,8 +669,13 @@ public boolean delete(TemplateProfile profile) {
// Remove template details
templateDetailsDao.removeDetails(template.getId());
- // Remove deploy-as-is details (if any)
- templateDeployAsIsDetailsDao.removeDetails(template.getId());
+ // Remove deploy-as-is details (if any and if there are no VMs
using it)
Review Comment:
letś make this a javadoc of a new method
##########
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##########
@@ -665,8 +669,13 @@ public boolean delete(TemplateProfile profile) {
// Remove template details
Review Comment:
letś delete this comment
##########
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##########
@@ -665,8 +669,13 @@ public boolean delete(TemplateProfile profile) {
// Remove template details
Review Comment:
letś delete this comment
##########
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##########
@@ -665,8 +669,13 @@ public boolean delete(TemplateProfile profile) {
// Remove template details
templateDetailsDao.removeDetails(template.getId());
- // Remove deploy-as-is details (if any)
- templateDeployAsIsDetailsDao.removeDetails(template.getId());
+ // Remove deploy-as-is details (if any and if there are no VMs
using it)
Review Comment:
letś make this a javadoc of a new method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
