shwstppr commented on code in PR #8115:
URL: https://github.com/apache/cloudstack/pull/8115#discussion_r1364872561
##########
server/src/main/java/com/cloud/template/HypervisorTemplateAdapter.java:
##########
@@ -665,9 +665,6 @@ public boolean delete(TemplateProfile profile) {
// Remove template details
templateDetailsDao.removeDetails(template.getId());
- // Remove deploy-as-is details (if any)
Review Comment:
I think we atleast need to add a check if the template is used by existing
VMs or not. If it is not used then I don't see a problem removing deployasis
details.
And maybe preserve specific details if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
