weizhouapache commented on code in PR #9470:
URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701845161
##########
server/src/main/java/com/cloud/api/ApiResponseHelper.java:
##########
@@ -5281,4 +5365,57 @@ public BucketResponse createBucketResponse(Bucket
bucket) {
populateAccount(bucketResponse, bucket.getAccountId());
return bucketResponse;
}
+
+ @Override
+ public ASNRangeResponse createASNumberRangeResponse(ASNumberRange
asnRange) {
+ ASNRangeResponse response = new ASNRangeResponse();
+ response.setId(asnRange.getUuid());
+ DataCenterVO zone =
ApiDBUtils.findZoneById(asnRange.getDataCenterId());
+ if (zone != null) {
+ response.setZoneId(zone.getUuid());
+ }
+ response.setStartASNumber(asnRange.getStartASNumber());
+ response.setEndASNumber(asnRange.getEndASNumber());
+ response.setCreated(asnRange.getCreated());
+ response.setObjectName("asnumberrange");
+ return response;
+ }
+
+ @Override
+ public ASNumberResponse createASNumberResponse(ASNumber asn) {
+ ASNumberResponse response = new ASNumberResponse();
+ response.setId(asn.getUuid());
+ if (asn.getAccountId() != null) {
+ Account account = ApiDBUtils.findAccountById(asn.getAccountId());
+ response.setAccountId(account.getUuid());
+ response.setAccountName(account.getAccountName());
+ }
+ if (asn.getDomainId() != null) {
+ DomainVO domain = ApiDBUtils.findDomainById(asn.getDomainId());
+ response.setDomainId(domain.getUuid());
+ response.setDomainName(domain.getName());
+ }
+ DataCenterVO zone = ApiDBUtils.findZoneById(asn.getDataCenterId());
+ response.setZoneId(zone.getUuid());
+ response.setZoneName(zone.getName());
+ response.setAsNumber(asn.getAsNumber());
+ ASNumberRangeVO range =
asNumberRangeDao.findById(asn.getAsNumberRangeId());
+ response.setAsNumberRangeId(range.getUuid());
+ String rangeText = String.format("%s-%s", range.getStartASNumber(),
range.getEndASNumber());
+ response.setAsNumberRange(rangeText);
Review Comment:
cc @nvazquez
a view might help, but it looks like be a minor issue I think.
Even if we list 100 as numbers, it will not take long time, as the
`data_center` and `as_number_range` table are normally quite small , as well as
`bgp_peers` table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
