weizhouapache commented on code in PR #9470:
URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701889651
##########
test/integration/smoke/test_network_ipv6.py:
##########
@@ -394,7 +394,7 @@ def getRouterProcessStatus(self, router, cmd):
cmd,
hypervisor=self.routerDetailsMap[router.id]['hypervisor']
)
- self.assertTrue(type(result) == list and len(result) > 0,
+ self.assertTrue(type(result) == list,
Review Comment:
I changed ssh_command to use `ssh -q` in tools/marvin/marvin/lib/utils.py
due to it, some warning messages are not returned, for example
```
Warning: Permanently added '10.0.xx.xx' (ED25519) to the list of known hosts.
```
therefore it is ok if the returned result is empty
The only regression I found is with
`test/integration/smoke/test_network_ipv6.py`, no other issues found (according
to the smoke test results)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
