weizhouapache commented on code in PR #9470:
URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701873038
##########
api/src/main/java/com/cloud/network/Network.java:
##########
@@ -412,12 +412,16 @@ public void setIp6Address(String ip6Address) {
String getGateway();
+ void setGateway(String gateway);
Review Comment:
@shwstppr
In this PR, users are able to create ROUTED network with cidrsize (gateway
and cidr are null), ACS will allocate a IPv4 subnet (like ipv6 subnet) to the
network. In this case, the gateway/cidr needs to be updated accordingly.
th methods `setCidr` and `setGateway` already exist in `NetworkVO`. However,
the class passed to `ExternalGuestNetworkGuru` class is `Network` , not
`NetworkVO`, therefore I promoted it to `Network` interface, otherwise we need
to change the type `Network` to "`? extends Network`" (or other) in all related
classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
