weizhouapache commented on code in PR #11932:
URL: https://github.com/apache/cloudstack/pull/11932#discussion_r2474793797
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -1340,7 +1340,11 @@ public String getMemBalloonStatsPeriod() {
@Override
public String toString() {
StringBuilder memBalloonBuilder = new StringBuilder();
- memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'>\n");
+ memBalloonBuilder.append("<memballoon model='" + memBalloonModel +
"'");
+ if (memBalloonModel != MemBalloonModel.NONE) {
Review Comment:
looks ok.
however, to be safer, I would still suggest you to add the libvirt and qemu
check.
you can reuse `s_qemuVersion` and `s_libvirtVersion` in the same class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
