sudo87 commented on PR #12404:
URL: https://github.com/apache/cloudstack/pull/12404#issuecomment-3738066667
Thanks @DaanHoogland for your review and suggestions. Let me know if my
response makes sense:
1. Per argument lambda is not supported, it will perform toString instead of
evaluation. It wont work the way we expect:
```
logger.debug("VM {} with XML configuration {} will be migrated to host {}.",
vmName, () -> maskSensitiveInfoInXML(xmlDesc), target);
```
2. logger.isDebugEnabled check is added to avoid maskSensitiveInfoInXML
invocation. Which is not expensive operation but not required if debug is not
enabled. We can definitely remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
