DaanHoogland commented on PR #12404:
URL: https://github.com/apache/cloudstack/pull/12404#issuecomment-3738315747
> 1. Per argument lambda is not supported, it will perform toString instead
of evaluation. It wont work the way we expect:
>
> ```
> logger.debug("VM {} with XML configuration {} will be migrated to host
{}.", vmName, () -> maskSensitiveInfoInXML(xmlDesc), target);
> ```
this is not how I read the documentation, but I haven’t tested it. it should
lazily evaluate the lambda ony if debug is enabled.
> 2. logger.isDebugEnabled check is added to avoid maskSensitiveInfoInXML
invocation. Which is not expensive operation but not required if debug is not
enabled. We can definitely remove it.
I do not care if point 1 is out of the way. It is just cleaner code. If you
are right about point 1 we have a bigger issue.
I do not think either should stop this PR, but in general my experience is
that follow-ups don’t happen,...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
