DaanHoogland commented on code in PR #12404:
URL: https://github.com/apache/cloudstack/pull/12404#discussion_r2681634525
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java:
##########
@@ -910,4 +910,11 @@ private boolean findSourceNode(Document doc, Node
diskNode, String vmName, Strin
}
return false;
}
+
+ public static String maskSensitiveInfoInXML(String xmlDesc) {
+ if (xmlDesc == null) return null;
+ // Mask VNC password in XML for logging
+ return
xmlDesc.replaceAll("(graphics\\s+[^>]*type=['\"]vnc['\"][^>]*passwd=['\"])([^'\"]*)(['\"])",
Review Comment:
we can also just remove it, btw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
