DaanHoogland commented on code in PR #12404:
URL: https://github.com/apache/cloudstack/pull/12404#discussion_r2681626860
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java:
##########
@@ -158,7 +158,7 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
final String target = command.getDestinationIp();
xmlDesc = dm.getXMLDesc(xmlFlag);
if (logger.isDebugEnabled()) {
- logger.debug(String.format("VM [%s] with XML configuration
[%s] will be migrated to host [%s].", vmName, xmlDesc, target));
+ logger.debug("VM {} with XML configuration {} will be migrated
to host {}.", vmName, maskSensitiveInfoInXML(xmlDesc), target);
}
Review Comment:
```suggestion
logger.debug("VM {} with XML configuration {} will be migrated
to host {}.", vmName, () -> maskSensitiveInfoInXML(xmlDesc), target);
```
just a suggestion, (may apply below as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
