nvazquez commented on code in PR #12571:
URL: https://github.com/apache/cloudstack/pull/12571#discussion_r2765423950
##########
engine/components-api/src/main/java/com/cloud/agent/AgentManager.java:
##########
@@ -54,6 +54,9 @@ public interface AgentManager {
"This timeout overrides the wait global config. This holds a comma
separated key value pairs containing timeout (in seconds) for specific
commands. " +
"For example: DhcpEntryCommand=600,
SavePasswordCommand=300, VmDataCommand=300", false);
+ ConfigKey<Integer> KVMHostDiscoverySshPort = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Integer.class,
Review Comment:
Hi guys, sorry but I don't see what the issue is defining this setting at
cluster level, I think trying to scope the setting/detail to host level may not
be necessary. Currently the host discovery port is hardcoded to be port 22
globally. This PR will give operators flexibility to set a custom port (in case
its needed) for hosts to be added on a cluster. What do you think? @winterhazel
@weizhouapache @sureshanaparti @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
