weizhouapache commented on code in PR #12571:
URL: https://github.com/apache/cloudstack/pull/12571#discussion_r2765816418
##########
engine/components-api/src/main/java/com/cloud/agent/AgentManager.java:
##########
@@ -54,6 +54,9 @@ public interface AgentManager {
"This timeout overrides the wait global config. This holds a comma
separated key value pairs containing timeout (in seconds) for specific
commands. " +
"For example: DhcpEntryCommand=600,
SavePasswordCommand=300, VmDataCommand=300", false);
+ ConfigKey<Integer> KVMHostDiscoverySshPort = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Integer.class,
Review Comment:
just an example, how to solve this ?
- host A: port 2222
- host B: port 2223
actually in the AddHost, the name of the parameter is `url` (the host URL)
it indicates that port should be supported, no API parameter changes needed
(+ no UI, no global config changes)
what we can do
- parse the host and port from the URL (java.net.URI can be used)
- connect to host using the port (use default port 22 if not found)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
