nvazquez commented on code in PR #12571:
URL: https://github.com/apache/cloudstack/pull/12571#discussion_r2765908270
##########
engine/components-api/src/main/java/com/cloud/agent/AgentManager.java:
##########
@@ -54,6 +54,9 @@ public interface AgentManager {
"This timeout overrides the wait global config. This holds a comma
separated key value pairs containing timeout (in seconds) for specific
commands. " +
"For example: DhcpEntryCommand=600,
SavePasswordCommand=300, VmDataCommand=300", false);
+ ConfigKey<Integer> KVMHostDiscoverySshPort = new
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Integer.class,
Review Comment:
@weizhouapache I like the idea, however instead of parsing the URL can we
simply add a new parameter/UI and keep the setting as a fallback to not rely on
the hardcoded value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
