DaanHoogland commented on code in PR #12571:
URL: https://github.com/apache/cloudstack/pull/12571#discussion_r2767600392


##########
engine/components-api/src/main/java/com/cloud/agent/AgentManager.java:
##########
@@ -54,6 +54,9 @@ public interface AgentManager {
             "This timeout overrides the wait global config. This holds a comma 
separated key value pairs containing timeout (in seconds) for specific 
commands. " +
                     "For example: DhcpEntryCommand=600, 
SavePasswordCommand=300, VmDataCommand=300", false);
 
+    ConfigKey<Integer> KVMHostDiscoverySshPort = new 
ConfigKey<>(ConfigKey.CATEGORY_ADVANCED, Integer.class,

Review Comment:
   Guys, we have a customer asking ffor a per cluster configuration, So I 
propose the following;
   if not part of the host field (i.e. localhost:22) check the host detail, 
else check the cluster setting, else 22.
   
   makes sense everybody?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to