Damans227 commented on code in PR #13592:
URL: https://github.com/apache/cloudstack/pull/13592#discussion_r3614781042
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterUpgradeWorker.java:
##########
@@ -63,6 +63,12 @@ protected void retrieveScriptFiles() {
upgradeScriptFile = retrieveScriptFile(upgradeScriptFilename);
}
+ @Override
+ protected void cleanupScriptFiles() {
Review Comment:
Doesn't this delete `upgradeScriptFile` too early? `deployProvider()` runs
per node in the loop and calls `cleanupScriptFiles()` in its own `finally`, and
since this is an `UpgradeWorker`, that hits this override and deletes
`upgradeScriptFile` before `runInstallScriptOnVM()` (next line) SCPs it. Could
this break the upgrade the first time a node needs the provider re-deployed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
