Damans227 commented on code in PR #13592:
URL: https://github.com/apache/cloudstack/pull/13592#discussion_r3614809130
##########
plugins/integrations/kubernetes-service/src/test/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorkerTest.java:
##########
@@ -229,4 +230,48 @@ public void
testGetMergedAffinityGroupIdsExplicitDedicationAlreadyInList() {
Assert.assertTrue(result.contains(99L));
Assert.assertTrue(result.contains(2L));
}
+
+ @Test
+ public void testCleanupScriptFilesDeletesAllTempFiles() throws Exception {
+ actionWorker.deploySecretsScriptFile =
File.createTempFile("deploy-cloudstack-secret", ".sh");
Review Comment:
Nit: these strings duplicate `actionWorker.deploySecretsScriptFilename` and
friends. Could reuse those constants instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
