Damans227 commented on code in PR #13592:
URL: https://github.com/apache/cloudstack/pull/13592#discussion_r3614793778
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/actionworkers/KubernetesClusterActionWorker.java:
##########
@@ -820,7 +839,11 @@ protected boolean deployProvider() {
if (!result.first()) {
logMessage(Level.INFO, "Provider files missing. Adding them
now", null);
retrieveScriptFiles();
- copyScripts(publicIpAddress, sshPort);
+ try {
Review Comment:
This same `try { copyScripts(...) } finally { cleanupScriptFiles(); }` block
shows up 3 times (here, `deployCsiDriver()`, and `autoscaleCluster()`). Could
this be a small shared helper, like `copyScriptsWithCleanup(nodeAddress,
sshPort)`, to avoid repeating it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
