Damans227 commented on code in PR #14378:
URL: https://github.com/apache/cloudstack/pull/14378#discussion_r4234041799
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtReplugNicCommandWrapper.java:
##########
@@ -64,9 +65,7 @@ public Answer execute(final ReplugNicCommand command, final
LibvirtComputingReso
final VifDriver newVifDriver =
libvirtComputingResource.getVifDriver(nic.getType(), nic.getName());
final InterfaceDef interfaceDef = newVifDriver.plug(nic, "Other
PV", oldPluggedNic.getModel().toString(), null);
- if (command.getDetails() != null) {
-
libvirtComputingResource.setInterfaceDefQueueSettings(command.getDetails(),
null, interfaceDef);
- }
+
libvirtComputingResource.setInterfaceDefQueueSettings(command.getDetails(),
null, interfaceDef, nic.getMultiqueueNumber(), command.getVMType() ==
VirtualMachine.Type.DomainRouter);
Review Comment:
makes sense, replug never gets the value from the offering so routers are
fine. can we still skip -1 when there is no cpu count, like the old code did?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
