bernardodemarco commented on code in PR #14378:
URL: https://github.com/apache/cloudstack/pull/14378#discussion_r4234479865
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -7471,6 +7475,26 @@ public NetworkOffering createNetworkOffering(final
NetworkOfferingBaseCmd cmd) {
return offering;
}
+ private void validateNetworkOfferingMultiqueueParameters(Integer
publicMultiqueueNumber, Integer privateMultiqueueNumber, GuestType guestType,
boolean forVpc) {
+ if (guestType == GuestType.L2 &&
ObjectUtils.anyNotNull(publicMultiqueueNumber, privateMultiqueueNumber)) {
+ throw new InvalidParameterValueException("Multiqueue parameters
cannot be specified for L2 network offerings.");
+ }
+
+ if (publicMultiqueueNumber != null) {
+ if (forVpc) {
+ throw new InvalidParameterValueException(String.format("The
[%s] parameter cannot be specified for offerings that are meant to be used for
VPC tiers.", ApiConstants.PUBLIC_MULTIQUEUE_NUMBER));
+ }
+
+ if (publicMultiqueueNumber <= 0 && publicMultiqueueNumber != -1) {
Review Comment:
@Damans227, done in
https://github.com/apache/cloudstack/pull/14378/changes/bcd79140b011bc0702adc731c4662668fee974e2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
