bernardodemarco commented on code in PR #14378:
URL: https://github.com/apache/cloudstack/pull/14378#discussion_r4233951597
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtReplugNicCommandWrapper.java:
##########
@@ -64,9 +65,7 @@ public Answer execute(final ReplugNicCommand command, final
LibvirtComputingReso
final VifDriver newVifDriver =
libvirtComputingResource.getVifDriver(nic.getType(), nic.getName());
final InterfaceDef interfaceDef = newVifDriver.plug(nic, "Other
PV", oldPluggedNic.getModel().toString(), null);
- if (command.getDetails() != null) {
-
libvirtComputingResource.setInterfaceDefQueueSettings(command.getDetails(),
null, interfaceDef);
- }
+
libvirtComputingResource.setInterfaceDefQueueSettings(command.getDetails(),
null, interfaceDef, nic.getMultiqueueNumber(), command.getVMType() ==
VirtualMachine.Type.DomainRouter);
Review Comment:
The current implementation does not consider multi-queue when replugging
NICs. For KVM, NIC replugging is only triggered by the `migrateVPC` and
`migrateNetwork` APIs, which I've never seen anyone use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
