DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993:
Securing Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134407495
##########
File path: agent/src/com/cloud/agent/dao/impl/PropertiesStorage.java
##########
@@ -51,6 +51,9 @@ public synchronized String get(String key) {
@Override
public synchronized void persist(String key, String value) {
+ if (!loadFromFile(_file)) {
+ s_logger.warn("Failed to load changes and then write to them");
Review comment:
the loadFromFile allready logs errors on failures. is this warn really what
we (all) want to do here? I'd expect a return or even a throw of some sort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
