DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993:
Securing Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134409161
##########
File path: agent/test/com/cloud/agent/AgentShellTest.java
##########
@@ -44,4 +48,15 @@ public void loadProperties() throws ConfigurationException {
Assert.assertNotNull(shell.getProperties());
Assert.assertFalse(shell.getProperties().entrySet().isEmpty());
}
+
+ @Test
+ public void testGetHost() {
+ AgentShell shell = new AgentShell();
+ List<String> hosts = Arrays.asList("10.1.1.1", "20.2.2.2", "30.3.3.3",
"2001:db8::1");
+ shell.setHost(StringUtils.listToCsvTags(hosts));
+ for (String host : hosts) {
Review comment:
:) :+1: I'd add the comment line that we expect the algorithm to be
round-robbing for this test to succeed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
