DaanHoogland commented on a change in pull request #2239: CLOUDSTACK-9993:
Securing Agents Communications
URL: https://github.com/apache/cloudstack/pull/2239#discussion_r134432679
##########
File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -1073,6 +1079,24 @@ public void orchestrateStart(final String vmUuid, final
Map<VirtualMachineProfil
if (s_logger.isDebugEnabled()) {
s_logger.debug("Start completed for VM " + vm);
}
+ final Host vmHost = _hostDao.findById(destHostId);
Review comment:
this method is already giant and should be chopped up for readability and
maintainability. Can you please factor this block out to a separate method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
