DaanHoogland commented on a change in pull request #2298: CLOUDSTACK-9620:
Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159544568
##########
File path:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -226,10 +310,12 @@ public void copyAsync(DataObject srcData, DataObject
destData, Host destHost, As
if (canHandleSrc) {
String errMsg = "This operation is not supported
(DataStoreCapabilities.STORAGE_SYSTEM_SNAPSHOT " +
- "not supported by source storage plug-in). " +
getSrcDataStoreMsg(srcData);
+ "not supported by source storage plug-in). " +
getDestDataStoreMsg(destData);
Review comment:
I'm to dumb to get this:
if we can handle the source:
we throw a message that we can not handle the destination?
fi????
I am sure the previous code wasn't very sensible either but *please* add
some comment for the mere mortals, here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
