DaanHoogland commented on a change in pull request #2298: CLOUDSTACK-9620:
Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159544919
##########
File path:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
##########
@@ -242,15 +328,99 @@ public void copyAsync(DataObject srcData, DataObject
destData, Host destHost, As
LOGGER.warn(errMsg);
+ invokeCallback(errMsg, callback);
+
throw new UnsupportedOperationException(errMsg);
}
handleCreateVolumeFromTemplateBothOnStorageSystem((TemplateInfo)srcData,
(VolumeInfo)destData, callback);
+ return;
+ } else if (srcData instanceof VolumeInfo && destData instanceof
VolumeInfo) {
Review comment:
Can you factor out some of the bits of this copyAsync method? It was way to
big te begin with and is getting even better with this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
