DaanHoogland commented on a change in pull request #2298: CLOUDSTACK-9620:
Enhancements for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159547184
##########
File path:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -1426,19 +1998,66 @@ private Answer attachVolume(Command cmd, DiskTO disk,
boolean isAttach, boolean
} catch (Throwable e) {
if (e instanceof RemoteException) {
s_logger.warn("Encounter remote exception to vCenter,
invalidate VMware session context");
+
hostService.invalidateServiceContext(null);
}
String msg = "";
- if (isAttach)
+
Review comment:
why this extra line? the String msg clearly belongs with the test following.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
