rafaelweingartner commented on a change in pull request #2503: Support multiple
volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r178036307
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -2778,9 +2838,25 @@ private void unmountVmfsDatastore(VmwareContext
context, VmwareHypervisorHost hy
for (Pair<ManagedObjectReference, String> host : hosts) {
HostMO hostMO = new HostMO(context, host.first());
- HostStorageSystemMO hostStorageSystemMO =
hostMO.getHostStorageSystemMO();
+ if (isDatastoreMounted(dsMO, hostMO)) {
+ HostStorageSystemMO hostStorageSystemMO =
hostMO.getHostStorageSystemMO();
+
+ hostStorageSystemMO.unmountVmfsVolume(getDatastoreUuid(dsMO,
hostMO));
+ }
+ }
+ }
+
+ private void unmountVmfsDatastore2(VmwareContext context,
VmwareHypervisorHost hyperHost, String datastoreName,
Review comment:
out of curiosity. Why do you have two methods with the same name? I mean, I
am seeing these new methods ending in 2. What is the difference with the
original ones?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
