rafaelweingartner commented on a change in pull request #2503: Support multiple
volume access groups per compute cluster
URL: https://github.com/apache/cloudstack/pull/2503#discussion_r178037684
##########
File path:
plugins/storage/volume/solidfire/src/main/java/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java
##########
@@ -344,17 +354,72 @@ public static SolidFireAccount
getAccount(SolidFireConnection sfConnection, Stri
}
}
- public static void hostAddedToOrRemovedFromCluster(long hostId, long
clusterId, boolean added, String storageProvider,
- ClusterDao clusterDao, ClusterDetailsDao clusterDetailsDao,
PrimaryDataStoreDao storagePoolDao,
- StoragePoolDetailsDao storagePoolDetailsDao, HostDao hostDao) {
+ private static boolean isCloudStackOnlyVag(SolidFireConnection
sfConnection, SolidFireVag sfVag) {
+ long[] volumeIds = sfVag.getVolumeIds();
+
+ if (volumeIds == null || volumeIds.length == 0) {
Review comment:
what about using `org.apache.commons.lang3.ArrayUtils.isEmpty(long[])` here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
