rafaelweingartner commented on a change in pull request #2848: Vmware offline
migration
URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233214939
##########
File path:
engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java
##########
@@ -1976,92 +1965,244 @@ public void storageMigration(final String vmUuid,
final StoragePool destPool) {
private void orchestrateStorageMigration(final String vmUuid, final
StoragePool destPool) {
final VMInstanceVO vm = _vmDao.findByUuid(vmUuid);
+ preStorageMigrationStateCheck(destPool, vm);
+
+ try {
+ if(s_logger.isDebugEnabled()) {
+ s_logger.debug(
+ String.format("Offline migration of %s vm %s with
volumes",
+ vm.getHypervisorType().toString(),
+ vm.getInstanceName()));
+ }
+
+ migrateThroughHypervisorOrStorage(destPool, vm);
+
+ } catch (ConcurrentOperationException
+ | InsufficientCapacityException // possibly
InsufficientVirtualNetworkCapacityException or
InsufficientAddressCapacityException
+ | StorageUnavailableException e) {
+ s_logger.debug("Failed to migration: " + e.toString());
+ throw new CloudRuntimeException("Failed to migration: " +
e.toString());
+ } finally {
+ try {
+ stateTransitTo(vm, Event.AgentReportStopped, null);
+ } catch (final NoTransitionException e) {
+ s_logger.debug("Failed to change vm state: " + e.toString());
+ throw new CloudRuntimeException("Failed to change vm state: "
+ e.toString());
+ }
+ }
+ }
+
+ private Answer[] attemptHypervisorMigration(StoragePool destPool,
VMInstanceVO vm) {
+ boolean migrationResult = false;
+ final HypervisorGuru hvGuru =
_hvGuruMgr.getGuru(vm.getHypervisorType());
+ // OfflineVmwareMigration: in case of vmware call vcenter to do it for
us.
+ // OfflineVmwareMigration: should we check the proximity of source and
destination
+ // OfflineVmwareMigration: if we are in the same
cluster/datacentre/pool or whatever?
+ // OfflineVmwareMigration: we are checking on success to optionally
delete an old vm if we are not
+ List<Command> commandsToSend = hvGuru.finalizeMigrate(vm, destPool);
+
+ Long hostId = vm.getHostId();
+ // OfflineVmwareMigration: probaby this is null when vm is stopped
+ if(hostId == null) {
+ hostId = vm.getLastHostId();
+ if (s_logger.isDebugEnabled()) {
+ s_logger.debug(String.format("host id is null, using last host
id %d", hostId) );
+ }
+ }
+
+ if(CollectionUtils.isNotEmpty(commandsToSend)) {
+ Commands commandsContainer = new Commands(commandsToSend.get(0));
+ try {
+ // OfflineVmwareMigration: change to the call back variety?
+ // OfflineVmwareMigration: getting a Long seq to be filled
with _agentMgr.send(hostId, commandsContainer, this)
+ Answer[] answers = _agentMgr.send(hostId, commandsContainer);
Review comment:
`return _agentMgr.send(hostId, commandsContainer);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
