rafaelweingartner commented on a change in pull request #2848: Vmware offline
migration
URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233213044
##########
File path:
engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java
##########
@@ -25,11 +25,28 @@
import com.cloud.agent.api.to.VirtualMachineTO;
import com.cloud.host.Host;
+/**
+ * interface to query how to move data around and to commision the moving
+ */
public interface DataMotionStrategy {
+ /**
+ * reports whether this instance can do a move from source to destination
+ * @param srcData object to move
+ * @param destData location to move it to
+ * @return the expertise level with which this instance knows how to
handle the move
+ */
StrategyPriority canHandle(DataObject srcData, DataObject destData);
StrategyPriority canHandle(Map<VolumeInfo, DataStore> volumeMap, Host
srcHost, Host destHost);
+ /**
+ * copy the source volume to its destination (on a host if not null)
Review comment:
what happens if the host is null?
Is it possible to be null when we get to this part of the code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
