rafaelweingartner commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233211822
########## File path: api/src/main/java/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java ########## @@ -120,4 +120,19 @@ public void execute() { } } + @Override + public String getSyncObjType() { + if (getSyncObjId() != null) { + return BaseAsyncCmd.migrationSyncObject; + } + return null; + } + + @Override + public Long getSyncObjId() { + if (getStoragePoolId() != null) { Review comment: If `getStoragePoolId()` != null, then return `getStoragePoolId()`, otherwise return null.... You can simple call `return getStoragePoolId()`. The result is the same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services