bwsw commented on a change in pull request #3036: Implemented capabilities for
snapshots and vm snapshots.
URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234734562
##########
File path:
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##########
@@ -1272,15 +1273,15 @@ public boolean configure(String name, Map<String,
Object> params) throws Configu
String value =
_configDao.getValue(Config.BackupSnapshotWait.toString());
- Type.HOURLY.setMax(SnapshotHourlyMax.value());
- Type.DAILY.setMax(SnapshotDailyMax.value());
- Type.WEEKLY.setMax(SnapshotWeeklyMax.value());
- Type.MONTHLY.setMax(SnapshotMonthlyMax.value());
+ Type.HOURLY.setMax(snapshotHourlyMax.value());
+ Type.DAILY.setMax(snapshotDailyMax.value());
+ Type.WEEKLY.setMax(snapshotWeeklyMax.value());
+ Type.MONTHLY.setMax(snapshotMonthlyMax.value());
_totalRetries =
NumbersUtil.parseInt(_configDao.getValue("total.retries"), 4);
_pauseInterval = 2 *
NumbersUtil.parseInt(_configDao.getValue("ping.interval"), 60);
- snapshotBackupRetries = BackupRetryAttempts.value();
- snapshotBackupRetryInterval = BackupRetryInterval.value();
+ snapshotBackupRetries = backupRetryAttempts.value();
Review comment:
@DaanHoogland this is no my code, don't dive into semantics. What I did is
tjust renamed variable to comply normal camel case style with refactoring
utility.
If I didn't get what you mean, please try to explain me one more time)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
