bwsw commented on a change in pull request #3036: Implemented capabilities for
snapshots and vm snapshots.
URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234736058
##########
File path:
engine/components-api/src/main/java/com/cloud/vm/snapshot/VMSnapshotManager.java
##########
@@ -28,14 +28,35 @@
public interface VMSnapshotManager extends VMSnapshotService, Manager {
- static final ConfigKey<Integer> VMSnapshotExpireInterval = new
ConfigKey<Integer>("Advanced", Integer.class, "vmsnapshot.expire.interval",
"-1",
- "VM Snapshot expire interval in hours", true,
ConfigKey.Scope.Account);
+ Integer defaultVirtualMachineSnapshotsMax = 10;
+ Integer defaultVirtualMachineJobCheckInterval = 3000;
+ Integer defaultVirtualMachineSnapshotExpireInterval = -1;
+ Integer defaultVirtualMachineSnapshotCreateWait = 1800;
- public static final int VMSNAPSHOTMAX = 10;
+ ConfigKey<Integer> virtualMachineSnapshotExpireInterval = new
ConfigKey<Integer>("Advanced",
Review comment:
@DaanHoogland Well, there are different kinds of coding conventions I have
met in the codebase. Why I use the style like that here? The answer is because
those definitions are used only once to define ConfigKey variables and some
kind of syntax sugar which improves manageability.
If it should be changed to a capitalized style, can do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
