DaanHoogland commented on issue #3851: vpc: set traffic type of private gateway IP to Public to fix keepalived misconfiguration URL: https://github.com/apache/cloudstack/pull/3851#issuecomment-580346081 code lgtm, I do not oversee the logic from an operations point of view. I think extensive test is needed for this one. Can you comment @weizhouapache ? What I mean is, is there some reliance on the vpc-pg being of type guest elsewhere in the code? And do we need to have keepalive guard on a private gateway in general? tnx
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
