weizhouapache commented on issue #3851: vpc: set traffic type of private gateway IP to Public to fix keepalived misconfiguration URL: https://github.com/apache/cloudstack/pull/3851#issuecomment-580633180 > ... > > > > Can you comment @weizhouapache ? > > > ... > > > And do we need to have keepalive guard on a private gateway in general? > > > > > > definitely no. > > meaning if a vpd on the pg fails we don't care? > @DaanHoogland the private gateway IP is configured in our VRs (Up in master VR and Down in backup VR). The gateway of private gateway is not configured in our VRs, it might be configured on some switches (of cloudstack platform or other platforms), similar as gateway of public IPs. > > The network corresponding to a private gateway is "Guest" network in database. > > But in keepalived configuration, we should not take it into consideration because it is not a vpc tier. > > Ok, I get that part, and than shouldn't we mark it public in the DB, or give it its own type? The idea of treating it as guest internally and as public on the VR somehow doesn't feel right. > > This is by no means a disqualification of your fix, but a question about the design. Maybe, in the future we can implement a more permanent design?? @DaanHoogland ideally there is a network type (eg PrivateGateway) defined for private gateway. However, it seems to be a big change in java code and python code (in vr), which might bring other issues. I prefer to fix an issue in easier and more stable way.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
