GabrielBrascher commented on a change in pull request #3851: vpc: set traffic
type of private gateway IP to Public to fix keepalived misconfiguration
URL: https://github.com/apache/cloudstack/pull/3851#discussion_r373119134
##########
File path:
server/src/main/java/com/cloud/network/router/CommandSetupHelper.java
##########
@@ -1101,4 +1105,14 @@ protected String getGuestDhcpRange(final NicProfile
guestNic, final Network gues
}
return dhcpRange;
}
+
+ private TrafficType getNetworkTrafficType(Network network) {
+ final VpcGatewayVO gateway =
_vpcGatewayDao.getVpcGatewayByNetworkId(network.getId());
+ if (gateway != null) {
+ s_logger.debug("network " + network.getId() + " is a vpc private
gateway, set traffic type to Public");
Review comment:
@ustcweizhou what do you think of adding also the network name? Sometimes it
annoys me to see a lot of IDs on the log and then go after a few selects to
understand what is really going on.
Having the network ID and name would be great for debugging :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
