weizhouapache commented on issue #3851: vpc: set traffic type of private gateway IP to Public to fix keepalived misconfiguration URL: https://github.com/apache/cloudstack/pull/3851#issuecomment-580420529 > code lgtm, I do not oversee the logic from an operations point of view. I think extensive test is needed for this one. > Can you comment @weizhouapache ? > What I mean is, is there some reliance on the vpc-pg being of type guest elsewhere in the code? @DaanHoogland the network type is intended to changed to public in commit https://github.com/apache/cloudstack/commit/f4f9b3ab4ef2ef34e4d8a04c6ebfbf0784497227 however, it does not work, for unknown reasons. > And do we need to have keepalive guard on a private gateway in general? definitely no. The network corresponding to a private gateway is "Guest" network in database. But in keepalived configuration, we should not take it into consideration because it is not a vpc tier. > tnx
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
